jadams-tresys commented on code in PR #1429:
URL: https://github.com/apache/daffodil/pull/1429#discussion_r1952674183
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/DFDLDefineVariable.scala:
##########
@@ -101,7 +101,7 @@ class DFDLDefineVariable private (node: Node, doc:
SchemaDocument)
this.SDE("Variables must have primitive type. Type was '%s'.",
typeQName.toPrettyString)
)
- final def createVariableInstance = variableRuntimeData.createVariableInstance
+ final def createVariableInstance =
variableRuntimeData.createVariableInstance()
Review Comment:
I was surprised to see that this didn't have test coverage, but sure enough
this doesn't get used anywhere and this line can be completely removed. Don't
know if we want to do it in this pull request or not though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
