stevedlawrence commented on code in PR #1429:
URL: https://github.com/apache/daffodil/pull/1429#discussion_r1952698152
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/DFDLDefineVariable.scala:
##########
@@ -101,7 +101,7 @@ class DFDLDefineVariable private (node: Node, doc:
SchemaDocument)
this.SDE("Variables must have primitive type. Type was '%s'.",
typeQName.toPrettyString)
)
- final def createVariableInstance = variableRuntimeData.createVariableInstance
+ final def createVariableInstance =
variableRuntimeData.createVariableInstance()
Review Comment:
I think somewhere else is was commented that we should avoid making changes
that aren't related to the 2.13 conversion. Various cleanups and removing dead
code probably want to wait until everything is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
