JeremyYao commented on code in PR #1197:
URL: https://github.com/apache/daffodil-vscode/pull/1197#discussion_r1985231664
##########
src/language/providers/utils.ts:
##########
@@ -49,10 +50,36 @@ const items = [
'import',
]
+export class XmlItem {
Review Comment:
Is an XmlItem a representation of a whole XML tag (<tag
attr="attrval"...></tag>) or an attribute or both?
##########
src/language/providers/attributeCompletion.ts:
##########
Review Comment:
Question: Correct me if I'm wrong, but the files under
src/language/providers provide functionality for auto suggestions or
completions? It also looks like it provides logic for determining when to show
the completions or not that relate to DFDL and what suggestions to show?
##########
package.json:
##########
@@ -36,7 +36,7 @@
"watch:svelte": "yarn webpack --env development=true -w -c
./src/svelte/webpack.config.js",
"watch:svelte-tests": "mocha -r ts-node/register -w
./src/svelte/tests/**/*.test.ts",
"watch:tdmlEditorJS": "esbuild src/tdmlEditor/webview/webview.js
--outfile=dist/views/tdmlEditor/webview/webview.js --bundle --platform=node
--format=cjs --watch",
- "webpack": "webpack --mode production --config
./webpack/ext-dev.webpack.config.js",
+ "webpack": "webpack --mode development --config
./webpack/ext-dev.webpack.config.js",
Review Comment:
I agree with using production mode for builds and figuring out a method for
having the mode change to development when debugging locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
