Re: [PR] Fix to remove dfdl prefix for dfdl attributes if the element containi… [daffodil-vscode]

Fri, 07 Mar 2025 11:21:14 -0800 


rthomas320 commented on code in PR #1197:
URL: https://github.com/apache/daffodil-vscode/pull/1197#discussion_r1985562230


##########
src/language/providers/utils.ts:
##########
@@ -49,10 +50,36 @@ const items = [
   'import',
 ]
 
+export class XmlItem {

Review Comment:
   It can be an XML element tag or an XML attribute. It does not represent an 
entire element definition. I think naming XmlElement would not be the correct 
description.  The class is defined in src/language/providers/utils.ts.
   
![image](https://github.com/user-attachments/assets/5efc4183-b924-4ddd-8876-08f1e63a7537)
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to