olabusayoT commented on code in PR #1479: URL: https://github.com/apache/daffodil/pull/1479#discussion_r2074091574
########## daffodil-runtime1/src/main/java/org/apache/daffodil/api/debugger/TraceDebuggerRunner.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.api.debugger; + +import org.apache.daffodil.runtime1.debugger.InteractiveDebugger; + +/** + * {@link DebuggerRunner} that writes verbose information about parsing to stdout + */ +public class TraceDebuggerRunner implements InteractiveDebuggerRunner { + public void init() { + // do nothing + } + + public void init(InteractiveDebugger id) { + // do nothing + } + + public String getCommand() { + return ""; + } + + public void lineOutput(String line) { + // do nothing Review Comment: This is the comment associated with that class in the original japi/sapi ```scala /* * The below class is empty and is not ever actually used. It is just a place * holder. Whenever the Java API uses it, it is translated to the appropriate * Scala debugger runner. It is marked final so that it cannot be extended, * since the Scala pattern matcher would still match and use the equivalent * Scala trace runner and lose any added functionality. One must extend the * DebuggerRunner to create their own debugger runner. */ ``` As such, I've moved it and renamed it to InteractiveTraceDebuggerRunner and it is final and only used for pattern matching It is supposed to do nothing, the actually TraceDebuggerRunner does print output -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
