mbeckerle commented on code in PR #1479: URL: https://github.com/apache/daffodil/pull/1479#discussion_r2074156171
########## daffodil-runtime1/src/main/java/org/apache/daffodil/api/validation/ValidationException.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.api.validation; + +public interface ValidationException extends ValidationFailure { Review Comment: Oh yeah, ValidationError is a DFDL thing. Well whatever this interface represents, it's not "AnythingException", so it shouldn't be named with that suffix period because that convention in Java code is just way to frequently used. Can't fight city hall here. ValidationExceptionInterface is a possibility if you want to suggest it can be always cast to a ValidationException, if that's true, but I don't think it is. If it is always castable to a Throwable, then ValidationThrowableInteface would work. Does our JAPI/SAPI offer this validator extensibility today? If not I'd suggest leaving this out of the API for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
