JeremyYao commented on PR #1403:
URL: https://github.com/apache/daffodil-vscode/pull/1403#issuecomment-3267381019
> It works because it's explicitly checking for an empty string in
getTDMLConfig and then calling getValidatedTDMLPath if it finds one. I still
don't think '' should be the default value here. I think we should default to
${AskForValidatedTDMLPath} and then check for that to see if we should be
prompting for a path (or hardcoding for generate).
>
> Now, how we handle an empty TDML path, I could make a case for a few
different ways. We could:
>
> * Display an informational message and let the user know that there's an
invalid path in their launch config
> * Prompt the user for the missing TDML path (same behavior as it does now)
> * Be consistent with an empty data path and display an ENOENT error
message (VSCode notification/error message, not Windows error message).
>
> Personally, I think option 2 is the best one, but I'd be okay with 1 as
well. I'll probably be creating a new ticket to fix what I've listed as option
3.
>
> We should also consider removing AskForTDMLPath as it's not used, and I
don't see a reason why we'd use it over AskForValidatedTDMLPath.
Implemented feedback in
https://github.com/apache/daffodil-vscode/pull/1403/commits/756b898fae9033dde6802174fcb397f0360a4f41.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
