JeremyYao commented on code in PR #1403:
URL: https://github.com/apache/daffodil-vscode/pull/1403#discussion_r2334322550
##########
src/daffodilDebugger/debugger.ts:
##########
@@ -58,12 +58,18 @@ async function getTDMLConfig(
config.schema.path = ''
config.tdmlConfig.path =
- config.tdmlConfig.path ||
- (await vscode.commands.executeCommand(
- 'extension.dfdl-debug.getValidatedTDMLPath'
- ))
+ config.tdmlConfig.path == '${AskForValidatedTDMLPath}'
+ ? await vscode.commands.executeCommand(
+ 'extension.dfdl-debug.getValidatedTDMLPath'
+ )
+ : config.tdmlConfig.path
- if (!config.tdmlConfig.path) return false
+ if (!config.tdmlConfig.path) {
+ vscode.window.showErrorMessage(
+ `Invalid path TDML Execute path ${config.tdmlConfig.path} was
specified!`
+ )
+ return false
+ }
Review Comment:
@michael-hoke, this is a good reference for what I described above.
https://sentry.io/answers/truthy-and-falsy-values-in-javascript/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
