JeremyYao commented on PR #1403:
URL: https://github.com/apache/daffodil-vscode/pull/1403#issuecomment-3267005475
> > > > > Why does this PR touch the default value for tdmlConfig.path?
> > > >
> > > >
> > > > If the user can't specify a custom pathing, then it should be
reflected in how the pathing for the generated TDML is set.
> > >
> > >
> > > I'm not sure I follow. Are you saying that since we're not allowing
the users to change the path, we should default to an empty string and then
hardcode it right before we start the debugging session?
> >
> >
> > The default TDML config values are the starting initialization values
for when we're creating new launch configurations. So, what this means is that
'' is the default value.
>
> I do not think that '' should be the default value. What if we used
`${AskForTDMLPath}` as the default value and added a block in
debugger.ts:getDebugger to handle this for the two cases? I think this should
also let us separate our PRs again.
From what I saw in my testing, it prompts for the TDML file. Let’s make sure
to test this pull request before discussing further. Testing instructions are
described in the PR opening message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
