JeremyYao commented on code in PR #1403:
URL: https://github.com/apache/daffodil-vscode/pull/1403#discussion_r2344014104


##########
src/daffodilDebugger/debugger.ts:
##########
@@ -78,7 +78,7 @@ async function getTDMLConfig(
   if (config?.tdmlConfig?.action === 'generate') {
     config.tdmlConfig.name =
       config.tdmlConfig.name || getDefaultTDMLTestCaseName()
-    config.tdmlConfig.path = config.tdmlConfig.path || getTmpTDMLFilePath()
+    config.tdmlConfig.path = getTmpTDMLFilePath()

Review Comment:
   > If you're going to leave this in and leave in that #1376 is closed by 
this, then this ticket needs to also implement the notification that Shane 
suggested - I'm not 100% sure what exactly to do with that yet. I'm pretty sure 
the result of the discussion earlier this week was to put it in the output 
stream, but I haven't gotten the chance to look at this again.
   
   Thanks for bringing this up. I'll go ahead omit `Closes #1376`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to