shanedell commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2414250897
##########
vite/package.vite.config.mjs:
##########
@@ -109,23 +121,38 @@ function copyToPkgDirPlugin() {
{ from: 'src/styles/styles.css', to: `${pkg_dir}/src/styles/styles.css` },
{ from: 'src/tdmlEditor/', to: `${pkg_dir}/src/tdmlEditor` },
]
- const serverPackageFolder = path.join(
- path.resolve('dist/package'),
- serverPackage
- )
-
- console.debug(`== [Vite] | serverPackageFolder: ${serverPackageFolder}`)
- // remove debugger package folder if exists
- if (fs.existsSync(serverPackageFolder)) {
- fs.rmSync(serverPackageFolder, { recursive: true })
+
+ const serverPackageFolders = {
+ scala2_12: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala2.12']}-${pkg_version}`
+ ),
+ scala2_13: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala2.13']}-${pkg_version}`
+ ),
+ scala3: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala3']}-${pkg_version}`
+ ),
Review Comment:
This makes sense. I would prefer doing a single bin as well but not sure how
to make `sbt-native-packager` work that way, so may be best to go multiple for
now, one for each scala binary version.
That question was for like when we run say `sbt test`. Will that just be
updating the build.sbt to download the daffodil release when ran, how would we
define what version to download in that case as well and how do we specify its
location say for the classpath so its imported correctly? It makes sense how we
are doing it with the binary files but wasn't sure how to do it otherwise say
in the build.sbt. I would think it would be best that we get the scala code to
handle the downloading of Daffodil CLI, I think I am just confused on where
exactly it goes
When downloading these cached version do you think we should the users home
directly like you said `~/.cache/daffodil-debugger/apache-daffodil-4.0.0-bin/`
or do we want to use the temp directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
