shanedell commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2417264747
##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/Utils.scala:
##########
@@ -70,3 +72,64 @@ object DataLeftOverUtils {
leftOverBitsText + dataHex + dataText
}
}
+
+/** Download and extract utils */
+object DownloadExtractUtils {
Review Comment:
So would you prefer I delete the download and extracting from the Scala code?
If so, what I could then do is:
- Update the `--daffodilVersion` to `--daffodilPath` that is only used by
the bash/bat files.
- The extension with pass `--daffodilPath` to give the location of where the
JARs files are and the bat/bash files append to the classpath.
- If the `--daffodilPath` is not specified default to
`~/.cache/daffodil-debugger/`.
- Maybe in this case we want to allow both `--daffodilVersion` and
`--daffodilPath` so that we can sure the proper directory is used.
- This would mostly be in an effort to support the user running the
debugger directly and not only relying on the extension to run it for them
- If the JARs don't already exist then the bash/bat files do the downloading
and extracting?
- This would mostly be in an effort to support the user running the
debugger directly and not only relying on the extension to run it for them
Does this seem like an okay approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
