stevedlawrence commented on code in PR #1577:
URL: https://github.com/apache/daffodil/pull/1577#discussion_r2440054540
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/ElementBaseGrammarMixin.scala:
##########
@@ -81,6 +82,20 @@ trait ElementBaseGrammarMixin
}
}
+ final lazy val checkDelimitedLengthEVDP: Unit = {
+ if (
+ optionEmptyValueDelimiterPolicy.isDefined
+ && emptyValueDelimiterPolicy != EmptyValueDelimiterPolicy.Both
+ && (hasInitiator || hasTerminator)
+ ) {
+ SDW(
+ WarnID.EmptyValueDelimiterPolicyWarning,
+ "dfdl:emptyValueDelimiterPolicy='%s' will be ignored as it's only
implemented for 'both'",
Review Comment:
I think Lola determined a number of tests started failing if we made it an
SDE/subset error. Part of the issue was that the IBM GeneralFormat defaults to
evdp="none", but I think alot of our own tests do this too. This only works
because none of the these tests have a field that actually parses as empty so
evdp doesn't matter. We could change all these schemas to use "both" instead of
"none", but a quick grep shows there are about 100 instances of evdp="none".
It's possible many of these uses don't actually have initiators/terminators, so
maybe we don't need to update all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
