olabusayoT commented on code in PR #1577:
URL: https://github.com/apache/daffodil/pull/1577#discussion_r2524381989
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/ElementBaseGrammarMixin.scala:
##########
@@ -81,6 +82,20 @@ trait ElementBaseGrammarMixin
}
}
+ final lazy val checkDelimitedLengthEVDP: Unit = {
+ if (
+ optionEmptyValueDelimiterPolicy.isDefined
+ && emptyValueDelimiterPolicy != EmptyValueDelimiterPolicy.Both
+ && (hasInitiator || hasTerminator)
+ ) {
+ SDW(
+ WarnID.EmptyValueDelimiterPolicyWarning,
+ "dfdl:emptyValueDelimiterPolicy='%s' will be ignored as it's only
implemented for 'both'",
Review Comment:
So turns out we didn't have a tunable, which I thought we did, and since we
plan to eventually implement EVDP we can figure out if we want to actually
support backwards compatibility and add a tunable during implementation.
WE took a look at encodingErrorPolicy and it does something similar with a
nyi warning that is not controlled by a tunable
```scala
// DFDL-935 to enable
schemaDefinitionWarningWhen(
WarnID.EncodingErrorPolicyError,
policy == EncodingErrorPolicy.Error,
"dfdl:encodingErrorPolicy=\"error\" is not yet implemented. The
'replace' value will be used."
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
