shanedell commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2413665710
##########
vite/package.vite.config.mjs:
##########
@@ -109,23 +121,38 @@ function copyToPkgDirPlugin() {
{ from: 'src/styles/styles.css', to: `${pkg_dir}/src/styles/styles.css` },
{ from: 'src/tdmlEditor/', to: `${pkg_dir}/src/tdmlEditor` },
]
- const serverPackageFolder = path.join(
- path.resolve('dist/package'),
- serverPackage
- )
-
- console.debug(`== [Vite] | serverPackageFolder: ${serverPackageFolder}`)
- // remove debugger package folder if exists
- if (fs.existsSync(serverPackageFolder)) {
- fs.rmSync(serverPackageFolder, { recursive: true })
+
+ const serverPackageFolders = {
+ scala2_12: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala2.12']}-${pkg_version}`
+ ),
+ scala2_13: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala2.13']}-${pkg_version}`
+ ),
+ scala3: path.join(
+ path.resolve('dist/package'),
+ `daffodil-debugger-${daffodilVersions['scala3']}-${pkg_version}`
+ ),
Review Comment:
So the main reason I did limit it to 3 was because I didn't think we would
want to support every version of Daffodil right off the bat.
Doing what you said makes sense by downloading the release, but wouldn't we
possibly want to move this debugger code somewhere else then so we can do a
deployment where, for all versions of Daffodil there is a debugger created,
publish and then the extension can just pull them? I think I might confusing
this possibly as in this comment
https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2411541064 and
in the link you posted it sounds like you are saying to download the Daffodil
CLI debugger and run that instead of this custom debugger is that right? Or are
you saying we should do something similar to for the the extensions debugger to
be able to download versions easily, meaning possibly moving this debugger
somewhere different so the extension does not have to build the debugger? I
think trying to bundle all of the debuggers inside of the extension will be
hard, especially when debugging locally thats why I keep asking about moving
the scala code.
I do have some updates to push up, where I heavily reduce the amount of
duplicated code that I think will make this look better. Plus I implemented
some of your other ideas. I will close out the ones I resolve as some I have
questions on as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
