stevedlawrence commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2411531271
##########
src/daffodilDebugger/utils.ts:
##########
@@ -59,33 +66,58 @@ export async function runDebugger(
dfdlDebugger: DFDLDebugger,
createTerminal: boolean = false
): Promise<vscode.Terminal> {
- const dfdlVersion = daffodilVersion(filePath)
+ if (!['2.12', '2.13', '3'].includes(dfdlDebugger.version)) {
+ vscode.window.showErrorMessage(
+ `DFDL Debugger Version ${dfdlDebugger.version} not supported. Supported
versions are 2.12, 2.13 and 3.`
Review Comment:
Yeah, if this is a launch config that a user can change I would suggest it
it wants to be a Daffodil versions and not scala versions. Many users might not
even realize scala is a thing so picking a specific Scala version would
probably be confusing. So something like what you suggest makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
