JeremyYao opened a new pull request, #1463:
URL: https://github.com/apache/daffodil-vscode/pull/1463

   Closes #1461
   
   ## Description
   
   This change removes the duplicate disposal behavior as observed in 
https://github.com/apache/daffodil-vscode/issues/1461#issuecomment-3398455824. 
More specifically, remove duplicate removeActiveSession() calls.
   
   ## Wiki
   
   - [x] I have determined that no documentation updates are needed for these 
changes
   - [ ] I have added following documentation for these changes
   
   ## Review Instructions including Screenshots
   
   **_PLEASE TEST ON MULTIPLE OS-es!!!!!!_** 
   **_PLEASE TEST ON MULTIPLE OS-es!!!!!!_** 
   **_PLEASE TEST ON MULTIPLE OS-es!!!!!!_** 
   **_PLEASE TEST ON MULTIPLE OS-es!!!!!!_** 
   **_PLEASE TEST ON MULTIPLE OS-es!!!!!!_** 
   
   ### Windows 10/11
   
   Follow the `Steps to Reproduce` section in 
https://github.com/apache/daffodil-vscode/issues/1461. 
   
   Verify that when you close on of the data editor windows. The background 
`java` cmd window doesn't close. 
   
   Also verify the DE functionality of the opened DE window(s) work. 
   
   ### Other OS-es
   Open multiple data editor windows as outlined in the `Steps to Reproduce` 
section in https://github.com/apache/daffodil-vscode/issues/1461. 
   
   Verify that when you close on of the data editor windows the DE 
functionality of the opened DE window(s) work. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to