shanedell commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2411499816
##########
src/launchWizard/launchWizard.ts:
##########
@@ -535,10 +535,21 @@ class LaunchWizard {
})
let dfdlDebugger: DFDLDebugger = defaultValues.dfdlDebugger
+
+ let debuggerVersionSelect = ''
+ let debuggerAllowedVersions = ['2', '3']
+ let debuggerVersion = dfdlDebugger.version
+ debuggerAllowedVersions.forEach((version) => {
+ if (version === debuggerVersion) {
+ debuggerVersionSelect += `<option selected
value="${version}">${version}</option>`
+ } else {
+ debuggerVersionSelect += `<option
value="${version}">${version}</option>`
+ }
+ })
Review Comment:
Yeah that is what it does currently. I will update it, but should I do only
allow selecting versions of 3.10.0, 3.11.0 and 4.0.0 or should it be allowed
more a direct input from the user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
