stevedlawrence commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2417351082
##########
package.json:
##########
@@ -3,7 +3,11 @@
"displayName": "Apache Daffodil™ Extension for Visual Studio Code",
"description": "Apache Daffodil™ Extension for Visual Studio Code providing
DFDL syntax highlighting, DFDL code completion, DFDL schema debugging, and data
editor",
"version": "1.4.2-SNAPSHOT",
- "daffodilVersion": "3.11.0",
+ "daffodilScalaVersions": {
+ "<=3.10.0,<3.11.0": "2.12",
Review Comment:
I think it's probably nice if there's are actual semvers that only match a
specifc a specific daffodil version. Especially if you implement some of my
other suggestions about using semver.
I would suggest either keeping <4.0.0, or changing it to =3.11.0. Similar to
3.10.0, it's very unlikely we will every release a 3.11.x, so doing =3.11.0 is
unlikely to ever have issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
