JeremyYao commented on code in PR #1468:
URL: https://github.com/apache/daffodil-vscode/pull/1468#discussion_r2452580243
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -595,11 +595,11 @@ class DaffodilConfigurationProvider
* Massage a debug configuration just before a debug session is being
launched,
* e.g. add all missing attributes to the debug configuration.
*/
- resolveDebugConfiguration(
+ async resolveDebugConfiguration(
Review Comment:
Could you walk me through on why this function is changed from a normal
function to an async one?
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -609,12 +609,28 @@ class DaffodilConfigurationProvider
config.debugServer = 4711
}
- if (!config.schema) {
- return vscode.window
- .showInformationMessage('Cannot find a schema to debug')
- .then((_) => {
- return undefined // abort launch
- })
+ if (!config.schema || config.schema.path == '') {
Review Comment:
I did a quick test to see if we omit `config.schema.path` if it would break
and it appears to change the order of the file prompts: input data first, and
then prompt for schema file.
Nothing seems to be broken functionality wise but the ordering does change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
