JeremyYao commented on code in PR #1468:
URL: https://github.com/apache/daffodil-vscode/pull/1468#discussion_r2452627021
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -595,11 +595,11 @@ class DaffodilConfigurationProvider
* Massage a debug configuration just before a debug session is being
launched,
* e.g. add all missing attributes to the debug configuration.
*/
- resolveDebugConfiguration(
+ async resolveDebugConfiguration(
Review Comment:
Could you confirm that's the case? I do see parts of the code that just use
`vscode.commands.executeCommand` without the `await`
like in src/tdmlEditor/index.ts
```Typescript
import * as vscode from 'vscode'
import { TDMLProvider } from './TDMLProvider'
import { AppConstants } from './utilities/constants'
let outputChannel: vscode.OutputChannel
export function activate(context: vscode.ExtensionContext) {
outputChannel = vscode.window.createOutputChannel('TDML Editor')
printChannelOutput('TDML Editor extension activated.', true)
let openPreviewCommand = vscode.commands.registerCommand(
AppConstants.openPreviewCommand,
() => {
const editor = vscode.window.activeTextEditor
vscode.commands.executeCommand(
'vscode.openWith',
editor?.document?.uri,
AppConstants.viewTypeId,
{
preview: true,
viewColumn: vscode.ViewColumn.Beside,
}
)
}
)
```
Could you try and see if omitting the async and the awaits cause the code
issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
