Ontiomacer commented on PR #1605:
URL: https://github.com/apache/daffodil/pull/1605#issuecomment-3698397623
Hey @stevedlawrence I did some of the fixes
### 1. Test intent clarification
* Renamed the TDML test case to `spaces_in_names_01`.
* Updated the TDML description to focus solely on verifying that TDML and
schema resources located in paths containing spaces are resolved correctly.
* Removed emphasis on global element name collisions, since that behavior is
incidental and already covered elsewhere.
### 2. Test reference alignment
* Updated `TestGeneral.scala` to reference `spaceInNames.tdml` instead of
the removed `namespaces.tdml`.
* Updated the Scala test to invoke `spaces_in_names_01`, keeping test names
consistent across TDML and Scala.
### 3. Broken space-handling in resource lookup
* Fixed `Misc.getResourceOption` (and related lookup paths) by removing the
premature `replaceAll("\\s", "%20")`.
* `Class.getResource` now receives raw classpath paths as expected,
restoring correct resolution for resources whose paths contain spaces.
* As a result, the updated space-related tests now validate successful
resolution instead of incorrectly expecting failure.
### 4. Scope
* The fix is intentionally limited to classpath resource lookup.
* Broader URI/URL normalization concerns are left unchanged and can be
addressed in a follow-up ticket if needed.
With these changes, TDML duplication is removed, coverage for paths
containing spaces is preserved, and the underlying resource resolution issue
that caused the test confusion is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
