stevedlawrence commented on code in PR #1605:
URL: https://github.com/apache/daffodil/pull/1605#discussion_r2655613304


##########
daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestGeneral.scala:
##########
@@ -133,4 +133,4 @@ class TestTunables extends TdmlTests {
   @Test def invalidRestrictionPolicyIgnore_01 = test
   @Test def invalidRestrictionPolicyValidate_01 = test
   @Test def invalidRestrictionPolicyValidate_02 = test
-}
+}

Review Comment:
   Please also add a newline to this file.



##########
daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestGeneral.scala:
##########


Review Comment:
   Please change the tdmlResource to reference `spacesInNames.tdml` and in the 
assertTrue. When we fix the spaces issue it will make it clear where the tdml 
file is to be used for testing.



##########
daffodil-core/src/main/scala/org/apache/daffodil/lib/util/Misc.scala:
##########
@@ -761,4 +761,4 @@ object Misc {
     }
   }
 
-}
+}

Review Comment:
   Please undo this change, files should end with a new line. This might 
require a change in your IDE settings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to