jadams-tresys commented on code in PR #1681:
URL: https://github.com/apache/daffodil/pull/1681#discussion_r3396297184
##########
daffodil-core/src/main/scala/org/apache/daffodil/runtime1/processors/VariableMap1.scala:
##########
@@ -121,7 +121,7 @@ class VariableInstance private (val rd:
VariableRuntimeData) extends Serializabl
}
override def toString: String =
- "VariableInstance(%s,%s,%s,%s)".format(state, value, rd,
rd.maybeDefaultValueExpr)
+ s"VariableInstance($state,$value,$rd,${rd.maybeDefaultValueExpr})"
Review Comment:
Unfortunately I don't remember where exactly I was seeing the .format calls
come up. It might have been from this line, but I went ahead and converted all
format calls in the file to string interpolation and don't see any toString
methods being involved in profiling anymore. If you want I can retest without
the changes again to see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
