jadams-tresys commented on code in PR #1681:
URL: https://github.com/apache/daffodil/pull/1681#discussion_r3396348869
##########
daffodil-core/src/main/scala/org/apache/daffodil/unparsers/runtime1/ElementUnparser.scala:
##########
@@ -298,7 +296,8 @@ class ElementSpecifiedLengthUnparser(
with RegularElementUnparserStartEndStrategy
with ElementSpecifiedLengthMixin {
- override def runtimeDependencies = maybeTargetLengthEv.toList.toVector
+ override def runtimeDependencies =
Review Comment:
Changing to val makes a lot of sense. I'll test that out, cause
runtimeDependencies was still showing up in the profiling data after these
changes, although it wasn't as significant. I can also look into changing
things to Arrays as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
