gdesrosiers1805 commented on code in PR #1685:
URL: https://github.com/apache/daffodil/pull/1685#discussion_r3436372488
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/RestrictionUnion.scala:
##########
@@ -394,7 +372,7 @@ sealed trait TypeChecks { self: Restriction =>
theContext.SDE("%s is not a valid Boolean value. Expected 'true' or
'false'.", x)
case (_, _) => {
// Perform conversions once
- val theValue = convertStringToBigDecimal(value, primType, theContext)
+ val theValue = calendarStringToBigDecimal(value, primType, theContext)
Review Comment:
This was the reason why I reverted that changed where that function you
mentioned to remove was put back and renamed. I tried the inlining idea both
cases then some of the tests started to fail when it tries to convert an
already integer string. so, I tried to follow what the previously removed
function was doing and because of the fallback idea. I thought it made more
sense to keep that logic in one place instead of duplicating it since the
inlining idea using the primtype to convert to JBigDecimal was not as simple as
we originally thought it would
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
