stevedlawrence commented on code in PR #1685:
URL: https://github.com/apache/daffodil/pull/1685#discussion_r3436465984
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/RestrictionUnion.scala:
##########
@@ -394,7 +372,7 @@ sealed trait TypeChecks { self: Restriction =>
theContext.SDE("%s is not a valid Boolean value. Expected 'true' or
'false'.", x)
case (_, _) => {
// Perform conversions once
- val theValue = convertStringToBigDecimal(value, primType, theContext)
+ val theValue = calendarStringToBigDecimal(value, primType, theContext)
Review Comment:
That's fair. I think combining all the logic into convertFacetToBigDecimal
might sovle that problem? Then we wouldn't need a falback since that function
knows about facet types and primtypes and shouldn't need a fallback since it
knows the exact format to expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
