westonpace commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2070947738
This also leads to a sort of "variant problem" for any code we write that handles `Expr`. For example, we have code that walks through an `Expr` and calculates which columns are referenced. The "Expr walking" code now has to be aware of both the `GetStructField` and the `ScalarUDF` variants of field access. It would be nicer I think if there was a single canonical way to represent a nested field access in `Expr`. For example, maybe the translation from `GetStructField` to `ScalarUDF` happens as part of the translation from `Expr` to `PhysicalExpr`? This way `Expr` only has `GetStructField` but there is still the flexibility to customize field access? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
