westonpace commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2071274206
> I don't think there is any particular motivation (or any reason that the conversion needs to be done at either spot) 🤔 I think, for me, it's just a general unease with having multiple ways of expressing the same thing. I feel like this can lead to "implicit layers" of the plan. For example, there is already some notion of "parse plan", "unoptimized logical plan" and "optimized logical plan", and "physical plan". The middle two are both represented by `Expr` which can be subtle. Do we now add "rewritten logical plan" to the list? Or maybe "rewritten" and "simplified" are just very transient states between "unoptimized" and "optimized" and I am blowing things out of proportion. Another way to tackle it could be to leave the concept of a `GetIndexedField` node at the parsing layer and pull it out of `Expr` (or deprecate). This would force the conversion to be done between the parse plan and the logical plan. That being said, my needs are met (thanks again for your help), and perfect is the enemy of the good, so I'm happy to leave well enough alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
