leerho commented on a change in pull request #319:
URL:
https://github.com/apache/incubator-datasketches-java/pull/319#discussion_r433391927
##########
File path: src/main/java/org/apache/datasketches/tuple/Intersection.java
##########
@@ -19,98 +19,176 @@
package org.apache.datasketches.tuple;
+import static java.lang.Math.ceil;
+import static java.lang.Math.max;
import static java.lang.Math.min;
+import static org.apache.datasketches.HashOperations.hashInsertOnly;
+import static org.apache.datasketches.HashOperations.hashSearch;
+import static org.apache.datasketches.Util.MIN_LG_NOM_LONGS;
+import static org.apache.datasketches.Util.ceilingPowerOf2;
import java.lang.reflect.Array;
-import org.apache.datasketches.ResizeFactor;
import org.apache.datasketches.SketchesStateException;
+
/**
* Computes an intersection of two or more generic tuple sketches.
- * A new instance represents the Universal Set.
- * Every update() computes an intersection with the internal set
- * and can only reduce the internal set.
+ * A new instance represents the Universal Set. Because the Universal Set
+ * cannot be realized a <i>getResult()</i> on a new instance will produce an
error.
+ * Every update() computes an intersection with the internal state, which will
never
+ * grow larger and may be reduced to zero.
+ *
* @param <S> Type of Summary
*/
+@SuppressWarnings("unchecked")
public class Intersection<S extends Summary> {
-
private final SummarySetOperations<S> summarySetOps_;
- private QuickSelectSketch<S> sketch_;
- private boolean isEmpty_;
- private long theta_;
- private boolean isFirstCall_;
+ //private QuickSelectSketch<S> sketch_;
Review comment:
Accident. Will remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
