davecromberge commented on pull request #319: URL: https://github.com/apache/incubator-datasketches-java/pull/319#issuecomment-637097701
> This is an excellent review! Thank you! I think the protocol is for you to "Resolve" the issues you found. Thanks for taking the time to respond to my comments, and for your helpful explanations! Unfortunately, I do not have the appropriate permissions to resolve my comments, as the button is not available to me on this repository. I know what you are referring to, but just don't have access in this case. I have instead opted to mark them all with a +1, as they have been addressed. One comment that I also did not raise is the Array of Doubles sketch - please let me know if there is any way in which I can help with this. I realise that this has been discussed in the dev forum and is probably beyond the scope of this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
