leerho opened a new pull request #324:
URL: https://github.com/apache/incubator-datasketches-java/pull/324
This is a massive PR and will be difficult to review.
- I've had to do lots of shuffling of methods between classes to place them
where they make the most sense.
- I was able to consolidate the compacting code into one new
`CompactOperations` class that handles all the corner cases. This cleaned up a
lot of code that was duplicative.
- I've extended the set operations code in both Theta and Tuple to be more
flexible and with similar API.
- All three operators (`Union, Intersection, AnotB`) can be executed
using stateful or stateless operations.
- This makes them easier to remember and the fact that they behave the
same in both Theta and Tuple should help users.
- I have not yet implemented these changes in the `ArrayOfDoubles`
implementation.
- Lots of documentation fixes where I came across them.
Go ahead and review this the best you can. Independent of the reviews I want
to run some characterization tests to make sure I didn't screw something up.
It passes all the unit tests plus more I added, .... but you never know :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
