leerho commented on a change in pull request #324:
URL:
https://github.com/apache/incubator-datasketches-java/pull/324#discussion_r452623175
##########
File path:
src/test/java/org/apache/datasketches/theta/PairwiseSetOperationsTest.java
##########
@@ -171,7 +171,7 @@ public void checkAnotBEarlyStop() {
CompactSketch csk2 = usk2.compact(true, null);
Sketch rsk = PairwiseSetOperations.aNotB(csk1, csk2);
- double result1 = rsk.getEstimate();
+ double result1 = rsk.getEstimate(); //null ptr
Review comment:
These were comments I was making in the code as I was troubleshooting
and forgot to go back and clean up. The entire PairwiseSetOperations class is
now deprecated since the main set operation classes now cover these pair
operations as part of their API. Eventually, when we move to version 3.0, we
can delete the deprecated classes and the tests associated with them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
