davecromberge commented on a change in pull request #324:
URL:
https://github.com/apache/incubator-datasketches-java/pull/324#discussion_r455396253
##########
File path: src/main/java/org/apache/datasketches/tuple/CompactSketch.java
##########
@@ -121,6 +121,11 @@
}
}
+ @Override
+ public CompactSketch<S> compact() {
+ return this;
+ }
Review comment:
I have looked through the additional changes, and yes, all the rest of
the points raised were resolved. Thank you for addressing them. I have also
read through the code related to the bug fixes mentioned and the additional
commentary on clearing memory is valuable.
Concerning discussion thread here, I am interested in how the summary may be
restricted. Were you considering adding an additional method to the summary
type to provide the size for the tuple?
If it is more involved, I am happy to pick this up on [DISCUSS] or not let
this block the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
