leerho commented on pull request #324: URL: https://github.com/apache/incubator-datasketches-java/pull/324#issuecomment-657888425
The 3 bugs: - The EMPTY_SKETCH_MASK in EmptyCompactSketch was not masking out the lgNomLongs and lgArrLongs fields. This would cause it to reject an otherwise valid empty compact sketch. - The `loadCompactMemory()` as part of `CompactOperations` (this is new) was not initializing the `lgNomLongs` and `lgArrLongs` fields to zero. This contributed to the 1st bug, especially when using off-heap memory. - The new centralized `memoryToCompact()` as part of `CompactOperations` was not properly loading the flags field into the destination compact sketch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
