AlexanderSaydakov commented on pull request #185: URL: https://github.com/apache/datasketches-cpp/pull/185#issuecomment-769581078
Why do you serialize union? We are removing this functionality from the new version as well as serialization of update sketch. Only compact sketches can be serialized. I am afraid I don't quite get your operation sequence. I would think that in the update phase the state of the aggregation should be update_theta_sketch, which should be converted to a compact_theta_sketch at the end of the phase, serialized and shipped to the merge phase. And the merge phase should only receive compact sketches to union them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
