AlexanderSaydakov commented on pull request #185: URL: https://github.com/apache/datasketches-cpp/pull/185#issuecomment-773644982
We have just promoted the experimental theta sketch implementation to replace the previous one. This creates a conflict with your proposed changes. Sorry for this confusion. I would suggest closing this request for now. If you really need this mixed union functionality, we can discuss it. However I still believe that we can easily do without. I still don't understand why you gave some examples above that don't show calling these methods. New implementation allows serializing compact sketches only. I strongly believe that serializing updatable sketches or unions should not be necessary. If you are facing some difficulty in Impala, let us discuss this. I suggest opening an issue for that. We want to help you. Thank you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
