leerho commented on code in PR #411:
URL: https://github.com/apache/datasketches-java/pull/411#discussion_r947085772
##########
src/test/java/org/apache/datasketches/kll/KllMiscFloatsTest.java:
##########
@@ -35,10 +35,22 @@
/**
* @author Lee Rhodes
*/
-public class MiscFloatsTest {
+public class KllMiscFloatsTest {
static final String LS = System.getProperty("line.separator");
private final MemoryRequestServer memReqSvr = new
DefaultMemoryRequestServer();
+ @Test
+ public void checkConvertToCumulative() {
+ long[] array = {1,2,3,2,1};
+ long out = KllHelper.convertToCumulative(array);
+ assertEquals(out, 9);
+ }
+
+ @Test
+ public void checkSortedViewConstruction() {
+
+ }
Review Comment:
Thank you for finding this! I will fill in the test with the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]