leerho commented on code in PR #411:
URL: https://github.com/apache/datasketches-java/pull/411#discussion_r947142792
##########
src/test/java/org/apache/datasketches/CrossCheckQuantilesTest.java:
##########
@@ -19,300 +19,219 @@
package org.apache.datasketches;
-import static org.apache.datasketches.CrossCheckQuantilesTest.PrimType.DOUBLE;
-import static org.apache.datasketches.CrossCheckQuantilesTest.PrimType.FLOAT;
-import static org.apache.datasketches.CrossCheckQuantilesTest.SkType.CLASSIC;
-import static org.apache.datasketches.CrossCheckQuantilesTest.SkType.KLL;
-import static org.apache.datasketches.CrossCheckQuantilesTest.SkType.REQ;
-import static
org.apache.datasketches.CrossCheckQuantilesTest.SkType.REQ_NO_DEDUP;
-import static org.apache.datasketches.CrossCheckQuantilesTest.SkType.REQ_SV;
+
+import static org.apache.datasketches.QuantileSearchCriteria.INCLUSIVE;
+import static org.apache.datasketches.QuantileSearchCriteria.NON_INCLUSIVE;
+import static
org.apache.datasketches.QuantileSearchCriteria.NON_INCLUSIVE_STRICT;
+import static org.apache.datasketches.ReflectUtility.KLL_DOUBLES_SV_CTOR;
+import static org.apache.datasketches.ReflectUtility.KLL_FLOATS_SV_CTOR;
+import static org.apache.datasketches.ReflectUtility.REQ_SV_CTOR;
import static org.testng.Assert.assertEquals;
+import org.apache.datasketches.kll.KllDoublesSketch;
+import org.apache.datasketches.kll.KllDoublesSketchSortedView;
import org.apache.datasketches.kll.KllFloatsSketch;
-import org.apache.datasketches.quantiles.DoublesSketch;
-import org.apache.datasketches.quantiles.UpdateDoublesSketch;
+import org.apache.datasketches.kll.KllFloatsSketchSortedView;
import org.apache.datasketches.req.ReqSketch;
-import org.apache.datasketches.req.ReqSketchBuilder;
import org.apache.datasketches.req.ReqSketchSortedView;
import org.testng.annotations.Test;
public class CrossCheckQuantilesTest {
- enum SkType { REQ, REQ_SV, REQ_NO_DEDUP, KLL, CLASSIC }
+ final int k = 32; //all sketches are in exact mode
- enum PrimType { DOUBLE, FLOAT }
+ //These test sets are specifically designed to test some tough corner cases
so don't mess with them
+ // unless you know what you are doing.
+ //These sets must start with 10 and be multiples of 10.
Review Comment:
Good point. Will do in next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
