AlexanderSaydakov commented on PR #342: URL: https://github.com/apache/datasketches-cpp/pull/342#issuecomment-1412567066
I think this is not quite right, and we did not do it quite right so far. operator*() should return reference but the reference can be defined to be the same as value_type for LegacyInputIterator in such cases when we return a proxy object by value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
