AlexanderSaydakov commented on code in PR #342:
URL: https://github.com/apache/datasketches-cpp/pull/342#discussion_r1093628515
##########
fi/include/reverse_purge_hash_map.hpp:
##########
@@ -91,8 +91,14 @@ class reverse_purge_hash_map {
// This iterator uses strides based on golden ratio to avoid clustering during
merge
template<typename K, typename V, typename H, typename E, typename A>
-class reverse_purge_hash_map<K, V, H, E, A>::iterator: public
std::iterator<std::input_iterator_tag, K> {
+class reverse_purge_hash_map<K, V, H, E, A>::iterator {
public:
+ using iterator_category = std::input_iterator_tag;
+ using value_type = std::pair<K&, V>;
+ using difference_type = std::ptrdiff_t;
Review Comment:
I think this can be void in this case. I would be much more comfortable not
specifying pointer difference for temporary values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
