This is an automated email from the ASF dual-hosted git repository. jmalkin pushed a commit to branch 5.0.X-backport in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit c91c2a66706449352cf06b7d3443d66ffef59e09 Author: Lee Rhodes <[email protected]> AuthorDate: Mon Feb 26 11:21:11 2024 -0800 While reviewing these changes again, I found some commented out lines that could be removed and some unnecessary minor changes that could be reverted. --- .../java/org/apache/datasketches/quantiles/ItemsSketchSortedView.java | 2 -- src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java | 2 ++ .../tuple/arrayofdoubles/ArrayOfDoublesQuickSelectSketch.java | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/apache/datasketches/quantiles/ItemsSketchSortedView.java b/src/main/java/org/apache/datasketches/quantiles/ItemsSketchSortedView.java index 08df7210..b4a8fd98 100644 --- a/src/main/java/org/apache/datasketches/quantiles/ItemsSketchSortedView.java +++ b/src/main/java/org/apache/datasketches/quantiles/ItemsSketchSortedView.java @@ -26,11 +26,9 @@ import static org.apache.datasketches.quantilescommon.QuantilesUtil.evenlySpaced import static org.apache.datasketches.quantilescommon.QuantilesUtil.getNaturalRank; import java.lang.reflect.Array; -//import java.util.Arrays; import java.util.Comparator; import org.apache.datasketches.common.SketchesArgumentException; -//import org.apache.datasketches.common.SketchesStateException; import org.apache.datasketches.quantilescommon.GenericInequalitySearch.Inequality; import org.apache.datasketches.quantilescommon.GenericPartitionBoundaries; import org.apache.datasketches.quantilescommon.GenericSortedView; diff --git a/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java b/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java index 59e27a42..1759f55a 100644 --- a/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java +++ b/src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java @@ -170,9 +170,11 @@ class QuickSelectSketch<S extends Summary> extends Sketch<S> { * @param mem Memory object with serialized QuickSelectSketch * @param deserializer the SummaryDeserializer * @param summaryFactory the SummaryFactory + * @deprecated As of 3.0.0, heapifying an UpdatableSketch is deprecated. * This capability will be removed in a future release. * Heapifying a CompactSketch is not deprecated. */ + @Deprecated QuickSelectSketch( final Memory mem, final SummaryDeserializer<S> deserializer, diff --git a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesQuickSelectSketch.java b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesQuickSelectSketch.java index 9a9962b1..c4a896a2 100644 --- a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesQuickSelectSketch.java +++ b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesQuickSelectSketch.java @@ -57,9 +57,7 @@ abstract class ArrayOfDoublesQuickSelectSketch extends ArrayOfDoublesUpdatableSk int rebuildThreshold_; //absolute value relative to current capacity int lgCurrentCapacity_; - ArrayOfDoublesQuickSelectSketch( - final int numValues, - final long seed) { + ArrayOfDoublesQuickSelectSketch(final int numValues, final long seed) { super(numValues, seed); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
