leerho commented on PR #554: URL: https://github.com/apache/datasketches-java/pull/554#issuecomment-2093564249
The part of the ds-java library that is Java version sensitive is the ds-memory component, which we use for off-heap management. And currently ds-memory is supported for Java 8 and 11. With Java 17, there is no longer a need for our Memory component as Java 17 incorporates the new Panama FFM capability as a preview (or incubation). The FFM will be far more capable and faster, since it leverages native code and built right into the language. With Java 17 for the ds-java library we are also going to break up our library into Java Modules (JPMS) as well as move the build tools to Gradle. This means you will only need to download the specific sketches you need which will be in separate jars. The Gradle build shouldn't impact you unless you wish to build from source. Also the JPMS shouldn't bother you since you can place all these modular jars on the classpath (instead of the module path) and everything should just work 😄. WRT the PR. I am still reviewing your code and I agree that the "isFixedWidth" or isItemFixedSize" (might be a little clearer) is a good contribution. But you might have a few more nuggets in there. WRT the graph. You won't find any formula for producing that graph in the paper. But it can be inferred from how the sketch grows, which is discussed in the paper. Building the graph is rather involved and uses code deep in the bowels of the sketch. I have written a utility that produces it for me, but it is pretty much for my own research. In your case, I don't think you want the graph, per se, I think what you want is the ability to compute the expected size based on K, n, and item size. That could be an improvement in the current getMaxSerializedSizeBytes(...) and make it more general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
