ZacBlanco commented on PR #554: URL: https://github.com/apache/datasketches-java/pull/554#issuecomment-2093665121
When you say "direct mode", I'm interpreting that as you referring to `KllDoublesSketch` rather than `KllItemsSketch<Double>`. If I am correct with that assumption, then yes I think we will be using them. After benchmarking, I'm convinced the performance benefit is going to be worth the additional implementation complexity on our side, so I would like to use them. Hence why I opened #556. That `long` version of the sketch should be the only other implementation that we will need as most numeric data that benefits from the sketches in the initial implementation is either `double` or `long`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
