jmalkin commented on code in PR #183:
URL:
https://github.com/apache/datasketches-memory/pull/183#discussion_r1600803866
##########
tools/MemoryCheckstyle.xml:
##########
@@ -36,9 +36,17 @@ under the License.
<property name="charset" value="UTF-8"/>
<property name="severity" value="warning"/>
<property name="fileExtensions" value="java"/>
+ <property name="basedir" value="${basedir}"/>
Review Comment:
why is this added? I seem to recall it caused issues with VS Code and we
removed it from ds-java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
