leerho commented on code in PR #183:
URL:
https://github.com/apache/datasketches-memory/pull/183#discussion_r1604224304
##########
tools/MemoryCheckstyle.xml:
##########
@@ -36,9 +36,17 @@ under the License.
<property name="charset" value="UTF-8"/>
<property name="severity" value="warning"/>
<property name="fileExtensions" value="java"/>
+ <property name="basedir" value="${basedir}"/>
Review Comment:
Sorry 'bout that. I was trying to figure out how to resolve ${basedir} and
it seems that the checkstyle plugin has to be declared in the pom in order for
this to happen.
Then I forgot that that property was still in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
