leerho opened a new pull request, #561:
URL: https://github.com/apache/datasketches-java/pull/561
In the main code, nearly all the corrections are in the Javadocs.
However, in the test code, there were many places where he was comparing a
long vs a float ('cause he copied the code from the float classes).
Also, he didn't check the test classes with printing enabled. There were
numerous places where the printf format expected an "%f" that should have
been a "%d".
Nonetheless, Zac did an amazing job of creating this KllLongsSketch,
considering the complexity of the code!
I also did a coverage tests and made sure that the coverage of the "longs"
classes were very close to the coverage of the comparable "doubles" and
"floats" classes -- and they were! This means that he was able to faithfully
translate all the relevant tests from float to longs and I did not find any
gaps in testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
