leerho commented on PR #561: URL: https://github.com/apache/datasketches-java/pull/561#issuecomment-2130586647
This is difficult to review because this view does not show the context. - To see the changes I made to Zac's code you will need to compare this branch at commit d41aafc against this branch at commit 201869e. - Another way to review this is to compare this code compared to sister classes like the relevant classes from the KllDoublesSketch. They should line up exactly except for the difference in the primitive, "double" verses "long". I use a separate application for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
