SYaoJun commented on PR #479:
URL: https://github.com/apache/datasketches-cpp/pull/479#issuecomment-3853713957
> I am not sure I support changing short one-line if statements like this
from
>
> if (condition) return 0;
>
> to
>
> if (condition) { return 0; }
>
> We did not establish any style requirements, and we use one-liners
throughout the C++ library. So why should we change the approach in this
particular class?
>
> There is no harm, of course, but this style is a bit more verbose. I would
not mind switching to this style if the community wants.
I appreciate your perspective. While this individual style change might seem
minor, I believe we should think bigger: implementing a `.clang-tidy`
configuration would provide long-term benefits for code consistency and
maintainability.
I'd like to propose we adopt a `.clang-tidy` from another Apache project as
a reference, then refactor this code to comply with it. As the codebase grows,
having explicit linting rules becomes essential. Without them, we risk
inconsistency and harder maintenance down the road.
Does this sound reasonable to you? We could start by researching
configurations from similar Apache projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
