SYaoJun commented on PR #479:
URL: https://github.com/apache/datasketches-cpp/pull/479#issuecomment-3860654090
> I tend to favor this idea, because I really like clean, readable, and
robust code.
>
> In the ds-Java library we use Checkstyle when possible and a
checkstyle.xml config file is checked in. (E.g., Checkstyle is not compatible
with Java 25 yet)
>
> However, I would only agree to this if
>
> 1. We agree as a group on the configuration rules. (E.g., “if (condition)
{ return 0; }” has been proven to be more robust against accidental edits. )
This should be done as the first step.
> 2. someone volunteers to go through the existing C++ code and fix and
carefully review the current style discrepancies. An automatic fixer tool
could be a disaster! That is a big job. And neither Alex nor I have the time
to do it. We could really use some help 🥹.
>
> It would be ideal if we had something similar for all the languages 🙂.
Thanks for the explanation — I’m aligned with this approach.
I’m willing to volunteer to go through the existing C++ code, carefully
review the style discrepancies, and apply fixes without relying on an automatic
formatter.
Once the team agrees on the Checkstyle configuration, I can start working on
this.
For reference, here is the Apache Arrow .clang-tidy configuration:
https://github.com/apache/arrow/blob/main/.clang-tidy
If the team agrees on adopting this configuration (or a close variant of
it), I can address the formatting issues incrementally, algorithm by algorithm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
